-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_forward: Support empty_shared_key parameter #9681
Merged
Merged
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
cosmo0920-handle-empty-shared-key
branch
from
December 3, 2024 13:01
2acc449
to
7aaeebe
Compare
cosmo0920
force-pushed
the
cosmo0920-handle-empty-shared-key
branch
from
December 3, 2024 14:05
7aaeebe
to
883242c
Compare
cosmo0920
changed the title
in_forward: Handle '' and "" or absent value for yaml value as an empty shared_key
in_forward: Support empty_shared_key parameter
Dec 3, 2024
Tested the PR and it is working as expected. |
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
December 4, 2024 07:31
Currently, we don't have any ETA for the next release of Fluent Bit 3.2. |
edsiper
requested changes
Dec 5, 2024
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-handle-empty-shared-key
branch
from
December 6, 2024 06:34
883242c
to
fcda579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unsupported case of the specification of classic format and yaml format of fluent-bit configuration.
In out_forward plugin, we already had supported
empty_shared_key
parameter.However, in_forward plugin does not support such parameter in the current master.
I implemented
empty_shared_key
parameter in in_forward plugin.Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1525
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.