-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: add support for EKS Pod Identity #9696
Open
zhihonl
wants to merge
7
commits into
fluent:master
Choose a base branch
from
zhihonl:eks-pod-identity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wesley Pettit <[email protected]>
This change brings the http credential provider in line with the latest spec and adds support for: - EKS Pod Identity - validate/support EKS credential link local IP 169.254.170.23 - Latest HTTP Provider spec: - AWS_CONTAINER_CREDENTIALS_RELATIVE_URI - AWS_CONTAINER_CREDENTIALS_FULL_URI - AWS_CONTAINER_AUTHORIZATION_TOKEN - AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
zhihonl
requested review from
PettitWesley,
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
December 6, 2024 20:22
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fluent Bit will not publish telemetry to CloudWatch when only EKS pod identity credential is present. This is because it does not use EKS pod identity as part of its credential provider chain.
We are making a change to Fluent Bit's AWS HTTPS credential functions to use the token provided in environment variable
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE
which is injected by EKS Pod Identity webhook to query endpoint specified inAWS_CONTAINER_CREDENTIALS_FULL_URI
environment variable to retrieve STS credentials.This PR is a replica of #9206 but merging the changes from @PettitWesley and @edsiper and also making the post-merge changes compatible with master branch.
Address #8550
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Used default configuration provided by AWS CloudWatch Observability add-on
Log output after adding proper IAM permissions to role associated with pod identity
Log output after removing proper IAM permissions to role associated with pod identity
Ran valgrind against HTTP credentail tests
Command
Output
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Need to modify FluentBit credential chain documentation here: https://github.com/fluent/fluent-bit-docs/blob/master/administration/aws-credentials.md
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.