-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter_nest: Lift warning log switch #9703
Open
drbugfinder-work
wants to merge
2
commits into
fluent:master
Choose a base branch
from
drbugfinder-work:nest-warning-switch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
filter_nest: Lift warning log switch #9703
drbugfinder-work
wants to merge
2
commits into
fluent:master
from
drbugfinder-work:nest-warning-switch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of lift, if there's no valid/matching key found and the content cannot be lifted, the filter will throw an error. However, there can be scenarios, where it is intended that sometimes the lift filter does not find a match (like two different kinds of logs with the same tag). Then these warnings should be disableable by the user. This commit adds an option to suppress these kind of warnings. Signed-off-by: Richard Treu <[email protected]>
drbugfinder-work
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
December 10, 2024 11:20
fluent-bit.conf
|
Debug Output
|
Valgrind output
|
Signed-off-by: Richard Treu <[email protected]>
drbugfinder-work
force-pushed
the
nest-warning-switch
branch
from
December 10, 2024 11:27
94a3c2c
to
5ad2d8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a configuration parameter called
suppress_warnings
, which will mute warnings about lift-errors, in case the user wants to. This can be helpful in cases like different log formats (with equally named keys inside) with the same tag. The feature is disabled by default.This PR furthermore adds the tag to the log messages to find the log source (helpful in case the filter matches multiple tags)
Fixes #7797 , Fixes #1707
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.