Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin prometheus client version #121

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Conversation

kouk
Copy link
Contributor

@kouk kouk commented Oct 8, 2019

The latest ruby client for prometheus seems to be incompatible with this plugin:

/ $ gem list | grep promethe
fluent-plugin-prometheus (1.6.0)
prometheus-client (0.10.0)

I get this on fluentd startup:

2019-10-08 12:00:53 +0000 [error]: #0 unexpected error error_class=ArgumentError error="wrong number of arguments (given 2, expected 1; required keyword: docstring)"
  2019-10-08 12:00:53 +0000 [error]: #0 /usr/lib/ruby/gems/2.5.0/gems/prometheus-client-0.10.0/lib/prometheus/client/registry.rb:56:in `gauge'
  2019-10-08 12:00:53 +0000 [error]: #0 /usr/lib/ruby/gems/2.5.0/gems/fluent-plugin-prometheus-1.6.0/lib/fluent/plugin/in_prometheus_output_monitor.rb:69:in `start'
  2019-10-08 12:00:53 +0000 [error]: #0 /usr/lib/ruby/gems/2.5.0/gems/fluentd-1.6.3/lib/fluent/compat/call_super_mixin.rb:42:in `start'

I don't know enough ruby to resolve the alleged compatibility problems, but pinning the client version fixes the issue for me.

see: prometheus/client_ruby#95

@repeatedly
Copy link
Member

duplicated: #120

@repeatedly repeatedly merged commit 3680018 into fluent:master Oct 8, 2019
@repeatedly
Copy link
Member

Duplicated but this patch is better because work with recent client version.

@kouk
Copy link
Contributor Author

kouk commented Oct 9, 2019

thank you @repeatedly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants