Multiple S3 buckets support for input, dynamic bucket names from SQS, and queue url override #364
Conversation
Added queue url to sqs section to override calling get_queue_url Changed the default tag to include the bucket name Signed-off-by: abdullahzen <[email protected]>
…test multiple s3 bucket names and queue url override for sqs Signed-off-by: abdullahzen <[email protected]>
Fixed wrong variable name in the input plugin Signed-off-by: abdullahzen <[email protected]>
abdullahzen
force-pushed
the
master
branch
2 times, most recently
from
bbf5d7a to
544ddfd
Compare
|
@cosmo0920 Can I get a review? thank you! |
| desc "S3 bucket name" | ||
| config_param :s3_bucket, :string | ||
| desc "S3 bucket name(s) separated by commas in case of multiple bucket names" | ||
| config_param :s3_buckets, :string |
There was a problem hiding this comment.
Changing parameter name breaks existing configurations.
We couldn't accept this change.
Instead, using deprecated attr in config_param and adding parameter conversion code are needed to accept this PR.
There was a problem hiding this comment.
Thank you for the review. I'll do the requested changes to make it backwards compatible and get back to you 👍
|
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days |
|
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days |
Changes made:
Fixes #342 : Usually this error is returned when the user doesn't have permission to call get_queue_url