Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop needless login action #1549

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Dec 18, 2024

It is needless to login action just to build for checking purpose.

@kenhys
Copy link
Contributor Author

kenhys commented Dec 18, 2024

ref.

kenhys#887

@kenhys
Copy link
Contributor Author

kenhys commented Dec 18, 2024

This might be troublesome feedback from contributor.

It is needless to login action just to build for checking purpose.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the drop-needless-login branch 2 times, most recently from a6f4d63 to 28cbf04 Compare January 20, 2025 03:28
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the drop-needless-login branch from 28cbf04 to c6aa56b Compare January 20, 2025 03:30
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit 0c19b68 into fluent:master Jan 20, 2025
36 checks passed
@kenhys kenhys deleted the drop-needless-login branch January 20, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants