remove redundant update for performance (#4248)

remove redundant update to avoid upper replicas update must has conflict error, although it's in retry.RetryOnConflict()

Signed-off-by: LiuXiang <[email protected]>

pkg/ctrl/affinity.go

@@ -17,8 +17,6 @@ limitations under the License.
 package ctrl
 
 import (
-	"context"
-
 	datav1alpha1 "github.com/fluid-cloudnative/fluid/api/v1alpha1"
 	"github.com/fluid-cloudnative/fluid/pkg/common"
 	"github.com/fluid-cloudnative/fluid/pkg/utils"
@@ -166,12 +164,6 @@ func (e *Helper) BuildWorkersAffinity(workers *appsv1.StatefulSet) (workersToUpd
 					dataset.Spec.NodeAffinity.Required
 			}
 		}
-
-		err = e.client.Update(context.TODO(), workersToUpdate)
-		if err != nil {
-			return workersToUpdate, err
-		}
-
 	}
 
 	return

pkg/ctrl/affinity_test.go

@@ -313,8 +313,7 @@ func TestBuildWorkersAffinityForEFCRuntime(t *testing.T) {
 			},
 			want: &v1.Affinity{
 				PodAntiAffinity: &v1.PodAntiAffinity{
-					// The fake client makes empty slice to nil
-					//PreferredDuringSchedulingIgnoredDuringExecution: []v1.WeightedPodAffinityTerm{},
+					PreferredDuringSchedulingIgnoredDuringExecution: []v1.WeightedPodAffinityTerm{},
 					RequiredDuringSchedulingIgnoredDuringExecution: []v1.PodAffinityTerm{
 						{
 							LabelSelector: &metav1.LabelSelector{