Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter_tizen] Update webview_flutter to 4.10.0 #809

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

seungsoo47
Copy link
Contributor

  • Update minimum Flutter and Dart version to 3.24 and 3.5.
  • Update the example main app.
  • Update webview_flutter to 4.10.0.
  • Update webview_flutter_platform_interface to 2.10.0.
  • Add enableZoom, setOnJavaScriptAlertDialog, setOnJavaScriptConfirmDialog, setOnJavaScriptTextInputDialog APIs.

Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update 23 and 24 line too.

-  webview_flutter: ^4.4.2
-  webview_flutter_platform_interface: ^2.6.0
+  webview_flutter: ^4.10.0
+  webview_flutter_platform_interface: ^2.10.0

+)
Could you share how to test enableZoom()? Does ewk_settings_force_zoom_set work properly?

packages/webview_flutter/tizen/src/webview.cc Outdated Show resolved Hide resolved
@seungsoo47
Copy link
Contributor Author

Please update 23 and 24 line too.

-  webview_flutter: ^4.4.2
-  webview_flutter_platform_interface: ^2.6.0
+  webview_flutter: ^4.10.0
+  webview_flutter_platform_interface: ^2.10.0

+) Could you share how to test enableZoom()? Does ewk_settings_force_zoom_set work properly?

Thank you for your review. Actually, we don't have any touch devices now, but I have connected the Tizen API to the API that we will use in the future. If you think it is unnecessary, I can remove the API implementation.

@seungsoo47 seungsoo47 merged commit 777966d into flutter-tizen:master Feb 17, 2025
6 checks passed
@seungsoo47
Copy link
Contributor Author

#758

@JSUYA
Copy link
Member

JSUYA commented Feb 17, 2025

manually published https://pub.dev/packages/webview_flutter_tizen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants