fix: don't try to access optional track settings #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some properties defined in `package:web/web.dart` are defined as non-nullable, while some browsers don't support them. In my case, `aspectRatio` is not defined for [Firefox](https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSettings/aspectRatio#browser_compatibility). This seems to be a problem with the IDL itself being inconsistent (see dart-lang/web#309). Checking availability before accessing the fields seems to be an endorsed method: dart-lang/web#181 (comment)
holzgeist
force-pushed
the
fix-optional-track-settings
branch
from
f0a542e to
fc82d90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some properties defined in
package:web/web.dartare defined as non-nullable, while some browsers don't support them. In my case,aspectRatiois not defined for Firefox, causing a failed non-null checkThis seems to be a problem with the IDL itself being inconsistent (see dart-lang/web#309).
Checking availability before accessing the fields seems to be an endorsed method: dart-lang/web#181 (comment)
I tried to refactor the code to use
settings.has(property)andsettings[propery]in a loop, but then we lose type conversion and our map only contains JSAny. It's a bit verbose, but it's the best I could come up with currently