Fix crash when closing a window with Alt+F4
in multi-win Flutter on Windows
#56501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158450.
As mentioned in #158450, the crash occurs because a destroyed object may be accessed if the window and view have already been destroyed by the time
KeyEventCallback
is called. This issue is not limited to theAlt+F4
system key; it may also occur if the window is closed using other key presses, such as pressingEnter
after navigating to a dialog's "Close" button.This PR proposes a fix that checks whether the view ID is still valid when the callback is invoked. If the view is invalid, the event is skipped for that view.
A unit test has been added to assert that the
KeyEventCallback
is invoked when the associated view is valid, and not invoked when the view is destroyed.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.