Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT LAND: But I'm really curious to see if anything blows up #56766

Draft
wants to merge 104 commits into
base: main
Choose a base branch
from
Draft

DO NOT LAND: But I'm really curious to see if anything blows up #56766

wants to merge 104 commits into from

Commits on Nov 23, 2024

  1. Migrate PlatformViewsController to Objective-C

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    2da92cb View commit details
    Browse the repository at this point in the history

  2. Add Obj-C wrapper to engine

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    3f6b2de View commit details
    Browse the repository at this point in the history

  3. Eliminate wrapper property on engine class

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    2416e53 View commit details
    Browse the repository at this point in the history

  4. Use wrapper class on FlutterViewController, FlutterViewEngineDelegate

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    8183daa View commit details
    Browse the repository at this point in the history

  5. Update AccessibilityBridge to use wrapper

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9230301 View commit details
    Browse the repository at this point in the history

  6. Pass wrapper to PlatformViewIOS

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    23e03a2 View commit details
    Browse the repository at this point in the history

  7. Pass wrapped class to IOSExternalViewEmbedder

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9dd337d View commit details
    Browse the repository at this point in the history

  8. Extract onMethodCall:result:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0966e0e View commit details
    Browse the repository at this point in the history

  9. Goodbye WeakPtr

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    431dda2 View commit details
    Browse the repository at this point in the history

  10. Format

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f4c64ad View commit details
    Browse the repository at this point in the history

  11. Migrate setTaskRunner

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    fc08ce4 View commit details
    Browse the repository at this point in the history

  12. SetTaskRunner

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    2810996 View commit details
    Browse the repository at this point in the history

  13. Migrate setFlutterView

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    8f994c4 View commit details
    Browse the repository at this point in the history

  14. Migrate [set]viewController

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    ff6fdb5 View commit details
    Browse the repository at this point in the history

  15. flutterViewContoller

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0037903 View commit details
    Browse the repository at this point in the history

  16. registerViewFactory:withId:policy:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5644c4f View commit details
    Browse the repository at this point in the history

  17. beginFrameWithSize:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    c8703c5 View commit details
    Browse the repository at this point in the history

  18. cancelFrame

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    c887bfe View commit details
    Browse the repository at this point in the history

  19. prerollCompositeEmbeddedView:withParams:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    aad6664 View commit details
    Browse the repository at this point in the history

  20. flutterTouchInterceptingViewForId:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    1ffcaa6 View commit details
    Browse the repository at this point in the history

  21. postPrerollActionWithThreadMerger:impellerEnabled:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    fd5dc58 View commit details
    Browse the repository at this point in the history

  22. endFrameWithResubmit:threadMerger:impellerEnabled:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    ba646ae View commit details
    Browse the repository at this point in the history

  23. compositeEmbeddedViewWithId:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    283c7fa View commit details
    Browse the repository at this point in the history

  24. reset

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    23f0a97 View commit details
    Browse the repository at this point in the history

  25. submitFrameWithGrContext:iosContext:frame:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    7967475 View commit details
    Browse the repository at this point in the history

  26. firstResponderPlatformViewId

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    7576e06 View commit details
    Browse the repository at this point in the history

  27. pushFilterToVisitedPlatformViews:withRect:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    bdf629f View commit details
    Browse the repository at this point in the history

  28. pushVisitedPlatformViewId:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    303b32d View commit details
    Browse the repository at this point in the history

  29. embeddedViewCount

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f774ca0 View commit details
    Browse the repository at this point in the history

  30. platformViewForId:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d21753b View commit details
    Browse the repository at this point in the history

  31. compositeView:withParams:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    99ddc89 View commit details
    Browse the repository at this point in the history

  32. compositionParamsForView:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    34390e6 View commit details
    Browse the repository at this point in the history

  33. Remove public instance getter

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    18a7851 View commit details
    Browse the repository at this point in the history

  34. Migrate to weak pointers

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e1742bc View commit details
    Browse the repository at this point in the history

  35. Move C++ class to implementation file

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    aa0e076 View commit details
    Browse the repository at this point in the history

  36. Switch to unique_ptr

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0c9adc6 View commit details
    Browse the repository at this point in the history

  37. Remove unused LayerPoolSize

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b580ed2 View commit details
    Browse the repository at this point in the history

  38. Extract PlatformViewData

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f1c7c7d View commit details
    Browse the repository at this point in the history

  39. Extract LayerData struct

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    48e8a45 View commit details
    Browse the repository at this point in the history

  40. Migrate FlutterPlatformViewsController.instance to a property 

    This is temporary until we can eliminate it.
    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    1c1c0e1 View commit details
    Browse the repository at this point in the history

  41. add taskRunner property

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0c2dbe0 View commit details
    Browse the repository at this point in the history

  42. Migreate flutterView to property

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f1f3c48 View commit details
    Browse the repository at this point in the history

  43. Migrate flutterViewController to property

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    04ac3f6 View commit details
    Browse the repository at this point in the history

  44. Migrate registerViewFactory impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    6a7c27d View commit details
    Browse the repository at this point in the history

  45. Migrate beginFrameWithSize: impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    416e118 View commit details
    Browse the repository at this point in the history

  46. Migrate postPrerollActionWithThreadMerger: impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    8437d7b View commit details
    Browse the repository at this point in the history

  47. Migrate cancelFrame impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9257a57 View commit details
    Browse the repository at this point in the history

  48. Migrate prerollCompositeEmbeddedView: impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    c363355 View commit details
    Browse the repository at this point in the history

  49. Migrate platformViewForId: impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e8c9750 View commit details
    Browse the repository at this point in the history

  50. Migrate flutterTouchInterceptingViewForId: impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    7cca9c5 View commit details
    Browse the repository at this point in the history

  51. Migrate endFrameWithResubmit: impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a998d21 View commit details
    Browse the repository at this point in the history

  52. Migrate compositeEmbeddedViewWithId:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    cb1519b View commit details
    Browse the repository at this point in the history

  53. Migrate reset impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    ede12b9 View commit details
    Browse the repository at this point in the history

  54. Migrate submitFrame impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    15f9764 View commit details
    Browse the repository at this point in the history

  55. Migrate pushFilterToVisitedPlatformViews impl

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5c8e0b0 View commit details
    Browse the repository at this point in the history

  56. Migrate pushVisitedPlatformViewId

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    20663d9 View commit details
    Browse the repository at this point in the history

  57. Migrate embeddedViewCount

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b6e7aea View commit details
    Browse the repository at this point in the history

  58. Delete GetCompositionParams

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b3ad201 View commit details
    Browse the repository at this point in the history

  59. Migrate resetFrameState

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    6eb0bc1 View commit details
    Browse the repository at this point in the history

  60. Migrate createMissingOverlays:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    42d673b View commit details
    Browse the repository at this point in the history

  61. Migrate performSubmit

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    70149e0 View commit details
    Browse the repository at this point in the history

  62. Migrate compositeView:withParams:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    c9153f4 View commit details
    Browse the repository at this point in the history

  63. Migrate viewsToDispose

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    62495b1 View commit details
    Browse the repository at this point in the history

  64. Migrate removeUnusedLayers:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    02bdf81 View commit details
    Browse the repository at this point in the history

  65. Migreate createLayerWithIosContext:

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    20be46a View commit details
    Browse the repository at this point in the history

  66. Migrate nextLayerInPool

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    ccfc428 View commit details
    Browse the repository at this point in the history

  67. Migrate bringLayersIntoView

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    1bb3392 View commit details
    Browse the repository at this point in the history

  68. Migrate applyMutators

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5d706fe View commit details
    Browse the repository at this point in the history

  69. Migrate clipViewSetMaskView

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    26b3afb View commit details
    Browse the repository at this point in the history

  70. Migrate constructor

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    894bb07 View commit details
    Browse the repository at this point in the history

  71. Migrate layer_pool

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b1f25d8 View commit details
    Browse the repository at this point in the history

  72. Migrate slices

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    cc73df9 View commit details
    Browse the repository at this point in the history

  73. Migrate flutter_view_, flutter_view_controller_

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    3461c8c View commit details
    Browse the repository at this point in the history

  74. Migrate mask_view_pool

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a6cab02 View commit details
    Browse the repository at this point in the history

  75. Migrate factories

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    493ea56 View commit details
    Browse the repository at this point in the history

  76. Migrate gesture_recognizers_blocking_policies

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    632893d View commit details
    Browse the repository at this point in the history

  77. frame_size and platform_task_runner

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    46e7de8 View commit details
    Browse the repository at this point in the history

  78. Migrate platform_views

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    728936c View commit details
    Browse the repository at this point in the history

  79. Remove unnecessary dynamic decls

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    22e3a79 View commit details
    Browse the repository at this point in the history

  80. Migrate current_composition_params

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    22aa5da View commit details
    Browse the repository at this point in the history

  81. Migrate views_to_dispose

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    1c2931d View commit details
    Browse the repository at this point in the history

  82. Migrate composition_order

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    fcda13b View commit details
    Browse the repository at this point in the history

  83. Migrate visited_platform_views

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d31b2f1 View commit details
    Browse the repository at this point in the history

  84. views_to_recomposite

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0f7b7f1 View commit details
    Browse the repository at this point in the history

  85. Migrate non_zero_origin_views

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    035e508 View commit details
    Browse the repository at this point in the history

  86. Migrate previous_composition order and had_platform_views

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    ad329de View commit details
    Browse the repository at this point in the history

  87. FORMAT

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    4ee5b82 View commit details
    Browse the repository at this point in the history

  88. Reorder

    @cbracken
    cbracken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9184dbb View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. Identifier cleanup

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    7326a7a View commit details
    Browse the repository at this point in the history

  2. More identifier renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    41f56fb View commit details
    Browse the repository at this point in the history

  3. Add a TODO

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    94dc77e View commit details
    Browse the repository at this point in the history

  4. More renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    b44ba77 View commit details
    Browse the repository at this point in the history

  5. More renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    1811be2 View commit details
    Browse the repository at this point in the history

  6. More renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    c50809a View commit details
    Browse the repository at this point in the history

  7. More renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    43a7e95 View commit details
    Browse the repository at this point in the history

  8. More renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    93e5fc6 View commit details
    Browse the repository at this point in the history

  9. More renames

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    b30daa0 View commit details
    Browse the repository at this point in the history

  10. Param renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    cb78b36 View commit details
    Browse the repository at this point in the history

  11. More param renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    8085428 View commit details
    Browse the repository at this point in the history

  12. more param renaming

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    1348e18 View commit details
    Browse the repository at this point in the history

  13. ivar rename but there's no point in this ivar

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    19d6bc0 View commit details
    Browse the repository at this point in the history

  14. Locals

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    b3f053e View commit details
    Browse the repository at this point in the history

  15. More locals... and done I think

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    6058423 View commit details
    Browse the repository at this point in the history

  16. Format

    @cbracken
    cbracken committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    6db991b View commit details
    Browse the repository at this point in the history