[interactive_media_ads] Adds internal wrapper for Android native CompanionAdSlot and CompanionAdSlot.ClickListener
#8131
+1,168
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
bparrishMines
changed the title
CompanionAdSlot and CompanionAdSlot.ClickListener
stuartmorgan
approved these changes
Nov 22, 2024
|
|
||
| val instance = mock<CompanionAdSlot>() | ||
| val width = 0L | ||
| val height = 0L |
There was a problem hiding this comment.
When passing values that will be verified, they should always be different from each other, so that a bug that accidentally swapped them would be caught by the test.
There was a problem hiding this comment.
Good catch! I usually try to, but forget sometimes.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 25, 2024
…ative `CompanionAdSlot` and `CompanionAdSlot.ClickListener` (flutter/packages#8131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.