Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router_builder]: Fix Parameter generates a warning #8889

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

CaoGiaHieu-dev
Copy link
Contributor

@CaoGiaHieu-dev CaoGiaHieu-dev commented Mar 19, 2025

Fix: flutter/flutter#164621

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I linked to at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under1.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@CaoGiaHieu-dev CaoGiaHieu-dev changed the title [go_router_builder]: Fix Typed route parameter generates a warning [go_router_builder]: Fix Parameter generates a warning Mar 19, 2025
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from hannah-hyj March 19, 2025 18:13
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Co-authored-by: chunhtai <[email protected]>
@chunhtai
Copy link
Contributor

Hi @CaoGiaHieu-dev you will also need to bump the version in package.yaml

@vware
Copy link

vware commented Mar 27, 2025

works well, thanks @CaoGiaHieu-dev

@CaoGiaHieu-dev CaoGiaHieu-dev requested a review from chunhtai March 29, 2025 12:55
@vware
Copy link

vware commented Apr 2, 2025

@chunhtai is there anything else needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router_builder] Typed route with an int parameter generates a warning
4 participants