Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General maintenance #25

Merged
merged 6 commits into from
Aug 26, 2023
Merged

General maintenance #25

merged 6 commits into from
Aug 26, 2023

Conversation

nohli
Copy link
Collaborator

@nohli nohli commented Aug 26, 2023

  • Update deprecated theme variables
  • Update gradle to fix Android build of example app
  • Increase compileSdkVersion to fix Android build of example app
  • auto-format

@nohli nohli requested a review from AlexV525 August 26, 2023 02:52
@AlexV525
Copy link
Member

We should also raise the environment constraints, right?

@nohli
Copy link
Collaborator Author

nohli commented Aug 26, 2023

I guess the new theme variables were first introduced in Flutter 2.10, updated the constrains.

@nohli nohli changed the title Update deprecated theme variables, auto-format General maintenance Aug 26, 2023
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nohli nohli merged commit 4f0aa75 into master Aug 26, 2023
1 check passed
@nohli nohli deleted the theme-deprecations branch August 26, 2023 14:40
@nohli
Copy link
Collaborator Author

nohli commented Aug 26, 2023

@AlexV525 could you please allow access for the workflow to publish to pub.dev?

FYI I've had the same issue with a new package that the link wouldn't work... But after I moved the package to a verified publisher on pub.dev, it worked without the need to any further authorization.

@AlexV525
Copy link
Member

FYI I've had the same issue with a new package that the link wouldn't work... But after I moved the package to a verified publisher on pub.dev, it worked without the need to any further authorization.

Do you mean the pub does not allow unknown publisher packages to update? Or we're having an infra issue? The credential is not owned by me so I'll have to collaborate with the team if necessary.

@AlexV525
Copy link
Member

I see the outdated authorization logs. I'll update them or transfer the package to our publisher ASAP.

@nohli
Copy link
Collaborator Author

nohli commented Aug 26, 2023

All I've observed is that the GitHub action prompts you to open a link on pub.dev, which appears to be invalid. However, when the package is associated with a verified publisher, it seems to function seamlessly without needing any link.

I'm open to volunteering and adding it to my account. Still, I remember there being an account from fluttercandies.

Thanks for your assistance 🙏🏽

@AlexV525
Copy link
Member

@nohli I've updated the credential and the package has been transferred to fluttercandies.com publisher. Could you verify the publish again?

@nohli
Copy link
Collaborator Author

nohli commented Aug 27, 2023

@AlexV525 thank you, great job!
I've jut restarted the workflow, and now it's published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants