fix(package_info_plus): data serialization converts installTime to St…

…ring instead of DateTime (#3464) Co-authored-by: Miguel Beltran <[email protected]>
fluttercommunity · Feb 6, 2025 · aa10ce7 · aa10ce7
1 parent dab9207
commit aa10ce7
Show file tree

Hide file tree

Showing 6 changed files with 55 additions and 7 deletions.
diff --git a/packages/package_info_plus/package_info_plus/example/ios/Flutter/AppFrameworkInfo.plist b/packages/package_info_plus/package_info_plus/example/ios/Flutter/AppFrameworkInfo.plist
@@ -21,6 +21,6 @@
   <key>CFBundleVersion</key>
   <string>1.0</string>
   <key>MinimumOSVersion</key>
-  <string>11.0</string>
+  <string>12.0</string>
 </dict>
 </plist>
diff --git a/packages/package_info_plus/package_info_plus/example/ios/Runner.xcodeproj/project.pbxproj b/packages/package_info_plus/package_info_plus/example/ios/Runner.xcodeproj/project.pbxproj
@@ -215,7 +215,7 @@
 		97C146E61CF9000F007C117D /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 1300;
+				LastUpgradeCheck = 1510;
 				ORGANIZATIONNAME = "";
 				TargetAttributes = {
 					331C8080294A63A400263BE5 = {

diff --git a/...lus/package_info_plus/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme b/...lus/package_info_plus/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1300"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/packages/package_info_plus/package_info_plus/example/ios/Runner/AppDelegate.swift b/packages/package_info_plus/package_info_plus/example/ios/Runner/AppDelegate.swift
@@ -1,7 +1,7 @@
 import UIKit
 import Flutter
 
-@UIApplicationMain
+@main
 @objc class AppDelegate: FlutterAppDelegate {
   override func application(
     _ application: UIApplication,

diff --git a/packages/package_info_plus/package_info_plus/lib/package_info_plus.dart b/packages/package_info_plus/package_info_plus/lib/package_info_plus.dart
@@ -221,7 +221,7 @@ class PackageInfo {
       'version': version,
       if (buildSignature.isNotEmpty) 'buildSignature': buildSignature,
       if (installerStore?.isNotEmpty ?? false) 'installerStore': installerStore,
-      if (installTime != null) 'installTime': installTime
+      if (installTime != null) 'installTime': installTime!.toIso8601String(),
     };
   }
 

diff --git a/packages/package_info_plus/package_info_plus/test/package_info_test.dart b/packages/package_info_plus/package_info_plus/test/package_info_test.dart
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import 'dart:convert';
+
 import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:package_info_plus/package_info_plus.dart';
@@ -155,7 +157,7 @@ void main() {
       'packageName': 'io.flutter.plugins.mockpackageinfoexample',
       'version': '1.1',
       'buildNumber': '2',
-      'installTime': now,
+      'installTime': now.toIso8601String(),
     });
 
     final nextWeek = now.add(const Duration(days: 7));
@@ -176,7 +178,53 @@ void main() {
       'buildNumber': '2',
       'buildSignature': 'deadbeef',
       'installerStore': 'testflight',
-      'installTime': nextWeek,
+      'installTime': nextWeek.toIso8601String(),
+    });
+  });
+
+  test('data supports null values', () async {
+    PackageInfo.setMockInitialValues(
+      appName: 'mock_package_info_example',
+      packageName: 'io.flutter.plugins.mockpackageinfoexample',
+      version: '1.1',
+      buildNumber: '2',
+      buildSignature: '',
+      installerStore: null,
+      installTime: null,
+    );
+    final info1 = await PackageInfo.fromPlatform();
+    expect(info1.data, {
+      'appName': 'mock_package_info_example',
+      'packageName': 'io.flutter.plugins.mockpackageinfoexample',
+      'version': '1.1',
+      'buildNumber': '2',
+    });
+  });
+
+  test('data can be converted to JSON and back', () async {
+    PackageInfo.setMockInitialValues(
+      appName: 'mock_package_info_example',
+      packageName: 'io.flutter.plugins.mockpackageinfoexample',
+      version: '1.1',
+      buildNumber: '2',
+      buildSignature: 'signature',
+      installerStore: 'store',
+      installTime: now,
+    );
+    final info1 = await PackageInfo.fromPlatform();
+
+    // Convert to Json and back to Map
+    final jsonData = jsonEncode(info1.data);
+    final parsedData = jsonDecode(jsonData);
+
+    expect(parsedData, {
+      'appName': 'mock_package_info_example',
+      'packageName': 'io.flutter.plugins.mockpackageinfoexample',
+      'version': '1.1',
+      'buildNumber': '2',
+      'buildSignature': 'signature',
+      'installerStore': 'store',
+      'installTime': now.toIso8601String(),
     });
   });
 }