Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to 2024 RIKEN tutorial for DYAD #29
Updates to 2024 RIKEN tutorial for DYAD #29
Changes from 1 commit
9db7e92
a4c730b
4adc40d
41bb218
c4e3f8c
223afdc
fe854e1
f036fa2
560a48e
223861e
72d56e4
26f6834
89980ed
eaf4b1a
50d7cd6
0ab14fc
13cc28c
b1a3143
07033e1
03f62e6
9af1117
9d1fecd
1613907
a874218
5428b9a
58ed703
fc7e37b
f84cd2c
96897bb
0d01733
f24bbed
14108ca
55e27e2
7051f86
0cb3fb0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hidden now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, just a minor thing, but since I'm not sure if we'll be giving this tutorial at JLESC again next year, I didn't think it made sense to keep for this version of the tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, @vsoch, I just realized that this change was in
flux.ipynb
. Part of the plan for this tutorial was to break that down into sections (indicated by the notebooks starting with numbers). All the content fromflux.ipynb
should already be in those notebooks, so do you think it's fine just to deleteflux.ipynb
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also just realized that
dyad.ipynb
is still here. I definitely want to delete that notebook. I'll make a commit for that in a secThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it out, so I can't say, but I would rely on your judgment - if you can confidently say nothing is lost it's OK to delete. I'll be running it locally (building now) and I can try to check too, but absence of something is often hard to detect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point.
For me, the biggest thing is to not have it seen by the attendees of the tutorial because I feel like that will get confusing. I could always remove it in
Dockerfile.spawn
. That way we still have the file on GitHub, but it won't be there to confuse the attendees.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think, @vsoch?