Skip to content

Commit

Permalink
Merge pull request #182 from jameshcorbett/rabbit-hostlist-memo
Browse files Browse the repository at this point in the history
dws: change rabbit memo to hostlist
  • Loading branch information
mergify[bot] authored Jul 16, 2024
2 parents 5451ad7 + ef5a6cd commit 3b4ff91
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/modules/coral2_dws.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def setup_cb(handle, _t, msg, k8s_api):
nodes_per_nnf[nnf_name] = nodes_per_nnf.get(nnf_name, 0) + 1
handle.rpc(
"job-manager.memo",
payload={"id": jobid, "memo": {"rabbits": list(nodes_per_nnf.keys())}},
payload={"id": jobid, "memo": {"rabbits": Hostlist(nodes_per_nnf.keys()).encode()}},
).then(log_rpc_response)
k8s_api.patch_namespaced_custom_object(
COMPUTE_CRD.group,
Expand Down
6 changes: 4 additions & 2 deletions t/t1002-dws-workflow-obj.t
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ test_expect_success 'job submission with valid DW string works' '
${jobid} epilog-start &&
flux job wait-event -vt 30 -m description=${EPILOG_NAME} \
${jobid} epilog-finish &&
flux job wait-event -vt 15 ${jobid} clean
flux job wait-event -vt 15 ${jobid} clean &&
flux jobs -n ${jobid} -o "{user.rabbits}" | flux hostlist -q -
'

test_expect_success 'job requesting copy-offload in DW string works' '
Expand Down Expand Up @@ -209,7 +210,8 @@ test_expect_success 'job submission with multiple valid DW strings on different
${jobid} epilog-start &&
flux job wait-event -vt 45 -m description=${EPILOG_NAME} \
${jobid} epilog-finish &&
flux job wait-event -vt 15 ${jobid} clean
flux job wait-event -vt 15 ${jobid} clean &&
flux jobs -n ${jobid} -o "{user.rabbits}" | flux hostlist -q -
'

test_expect_success 'job submission with multiple valid DW strings on the same line works' '
Expand Down

0 comments on commit 3b4ff91

Please sign in to comment.