ci: updates, add lint and format checks #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshcorbett
force-pushed
the
ci-updates
branch
from
72af51a to
7d194a1
Compare
Problem: github's CI `main.yml` has not been updated in a long time. Update it.
Problem: flux-coral2's code should be formatted consistently with other flux-framework projects. Copy over .clang-format from flux-sched.
Problem: there is no github action to enforce code style and format, and also to lint. Add an action, pre-commit hooks, and a ruff format file.
Problem: now that CI enforces style, files need to be formatted to pass. Format everything.
jameshcorbett
force-pushed
the
ci-updates
branch
from
ab82928 to
4210dad
Compare
cmoussa1
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271.