coral2_dws: refactor badrabbit property
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the `mark_rabbit` function returns after setting or removing the `badrabbit` property on a single compute node, because of misplaced return statements. Fix it.
Problem: in order to minimize the size of `flux resource drain` output, drain messages should be identical. This implies that node-dependent information (such as rabbit hostname) should not be there. Remove the rabbit hostname from the drain message.
Problem: there are three different kinds of handling for down rabbits, and the code for them is messy. First, there is draining compute nodes. Second, there is marking rabbit vertices down in Fluxion. Lastly and most recently added, there is the setting of the `badrabbit` property on nodes. The third method is the most complicated and the code implementing it is mixed in with the code for the other two types of handling. It should be broken out to be handled separately and more cleanly. Break out the property logic into its own function.
cmoussa1
approved these changes
Feb 18, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes, and one kinda messy refactoring that doesn't change any functionality.