dws-jobtap: avoid setting aux too early #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: as described in flux-framework#285, the `dws-jobtap` plugin creates a boolean jobtap aux to indicate whether or not the prolog it sets on jobs is still active, but it creates the aux in the DEPEND state despite the fact that it will not start the prolog until the RUN state. If Flux is restarted with jobs in the queue, the aux will be lost and a lookup for the aux will cause the RUN callback to fail. Only set the `prolog_active` aux at the time that the prolog is actually started, and not before. Fixes flux-framework#285.
Problem: there are some duplicated string constants lying around dws-jobtap.c. Reduce them with a macro.
Problem: there are a number of places where errors in the execution of the dws-jobtap plugin causes callbacks to return -1 and an error to be logged, but no exception is raised. This could potentially lead to jobs stranded in strange states. Add exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: as described in #285, the
dws-jobtapplugin creates a boolean jobtap aux to indicate whether or not the prolog it sets on jobs is still active, but it creates the aux in the DEPEND state despite the fact that it will not start the prolog until the RUN state. If Flux is restarted with jobs in the queue, the aux will be lost and a lookup for the aux will cause the RUN callback to fail.Only set the
prolog_activeaux at the time that the prolog is actually started, and not before.Fixes #285.