Skip to content

Commit

Permalink
broker: drop unused module cred
Browse files Browse the repository at this point in the history
Problem: the broker module internally defines a message credential
that is no longer used, now that the interthread connector does that.

Drop it.
  • Loading branch information
garlick committed Oct 13, 2023
1 parent 1bfab47 commit 6605bec
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/broker/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ struct broker_module {

flux_t *h_broker; /* broker end of interthread channel */
char uri[128];
struct flux_msg_cred cred; /* cred of connection */

uuid_t uuid; /* uuid for unique request sender identity */
char uuid_str[UUID_STR_LEN];
Expand Down Expand Up @@ -372,13 +371,6 @@ module_t *module_create (flux_t *h,
errprintf (error, "could not create %s flux handle watcher", p->name);
goto cleanup;
}
/* Set creds for connection.
* Since this is a point to point connection between broker threads,
* credentials are always those of the instance owner.
*/
p->cred.userid = getuid ();
p->cred.rolemask = FLUX_ROLE_OWNER | FLUX_ROLE_LOCAL;

/* Optimization: create attribute cache to be primed in the module's
* flux_t handle. Priming the cache avoids a synchronous RPC from
* flux_attr_get(3) for common attrs like rank, etc.
Expand Down

0 comments on commit 6605bec

Please sign in to comment.