Merge pull request #6276 from wihobbs/version-error

configure: add check for valid version

configure.ac

@@ -36,6 +36,28 @@ AC_SUBST([AX_MAJOR_VERSION])
 AC_SUBST([AX_MINOR_VERSION])
 AC_SUBST([AX_POINT_VERSION])
 
+AC_MSG_CHECKING([whether version number is sane])
+AS_IF([printf "%d.%d.%d" ${AX_MAJOR_VERSION} ${AX_MINOR_VERSION} ${AX_POINT_VERSION} >/dev/null 2>&1], [
+    AC_MSG_RESULT([yes])
+],[
+    AC_MSG_RESULT([no])
+    version_err_msg="
+    VERSION ${VERSION} is invalid.
+    Try the following to remedy this:
+    
+      1. Run \`git fetch --tags\` before building. Versions in 
+         flux-core are derived from \`git describe\` which uses
+	 the most recent tag.
+      2. If you are running remote CI in a fork of the main repository, 
+         try pushing the upstream tags to your fork with
+	 \`git push --tags <your_remote>\` to make sure tags are 
+	 synchronized in your fork.
+      3. Set the variable manually, with FLUX_VERSION=<version>
+         in your environment.
+    "
+    AC_MSG_ERROR(["${version_err_msg}"])
+])
+
 ##
 # Initialize pkg-config for PKG_CHECK_MODULES to avoid conditional issues
 ##