ci: add flux-pmix, flux-pam builds to CI #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Changes proposed in a flux-core PR could break flux-pmix and this could go undetected for some time. Add a build and test of flux-pmix to the flux-core github workflow so that PRs that might break flux-pmix are discovered when proposed.
Problem: A change that breaks flux-pam could be proposed in a flux-core PR and go undetected. Add a build of flux-pam to the flux-core github workflow so these issues are discovered immediately.
Problem: `after_n_builds: 2` is set for the codecov `comment` section, but to be truly effective it may have to also be set in `codecov.notify`. Add an `after_n_builds: 2` setting in the `codecov.notify` section of `codecov.yml` in hopes this will get the feature working properly.
Problem: codeql action is having trouble with ubuntu repos. Try running apt-get update before installing deps.
Problem: The readthedocs build is failing with ImportError: cannot import name 'environmentfilter' from 'jinja2' As suggested on the internets, pin jinja2<3.1.0 to fix this issue.
Problem: The default flux-security version used in ci is v0.9.0, but the latest is v0.10.0. Update the default FLUX_SECURITY_VERSION in docker-run-check.sh to v0.10.0.
|
I also fixed the readthedocs build by pinning Additionally, I noticed that |
Codecov Report
@@ Coverage Diff @@
## master #5489 +/- ##
==========================================
- Coverage 83.64% 83.62% -0.02%
==========================================
Files 484 484
Lines 81443 81443
==========================================
- Hits 68120 68110 -10
- Misses 13323 13333 +10 |
|
Thanks! Setting MWP... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the flux-pmix and flux-pam builds to CI to ensure PRs do not break the build/test of these projects.
flux-pam is probably less useful, but it is so quick to build I threw it in there.
This also fixes the
after_n_buildssupport for codecov which might hopefully reduce the extra reporting we get for coverage.