python: fix handling of JobInfo properties and to_dict() method with missing attributes
#5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When a JobInfo is not fully populated with attributes, e.g. when not all attrs were requested in a job-list RPC, or when using flux.job.result(), the to_dict() method raises an AttributeError exception because some derived attributes are not present in the JobInfo object. Skip attributes that raise AttributeError.
Problem: If the status and/or expiration properties of a JobInfo object are not set, then getting the t_remaining attribute throws an AttributeError, but this attribute should instead be set to 0.0 when unset. Add a try/except block around the calculation of remaining time and return 0.0 for this attribute if AttributeError or KeyError are caught.
Problem: Testing of the returned JobInfo objects from flux.job.result() does not include ensuring that the to_dict method works and that accessing the t_remaining property doesn't raise an exception. Enhance the testing of flux.job.result() to include this testing.
Codecov Report
@@ Coverage Diff @@
## master #5493 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 484 484
Lines 81487 81493 +6
=======================================
+ Hits 68169 68176 +7
+ Misses 13318 13317 -1
|
|
I tested it in a container with the same commands I put in #5491 and it works great. |
|
Thanks @jameshcorbett and @wihobbs. I'll set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5491, however it does it in two ways
t_remainingJobInfoattribute whenexpirationand/orstatusattrs are missingto_dict()This allows
to_dict()to work withJobInfoobjects returned fromflux.job.result().