testsuite: trivial test fixes #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Some versions of jq(1) do not have the math `round` function, which causes a test in t2290-job-update.t to fail. Use `floor` instead to implement the test.
Problem: valgrind detects a leak in libflux test_disconnect.t. Free the message returned by flux_recv(3) to fix the leak. Fixes flux-framework#5497
garlick
approved these changes
Oct 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #5498 +/- ##
==========================================
+ Coverage 83.68% 83.70% +0.01%
==========================================
Files 484 484
Lines 81561 81561
==========================================
+ Hits 68257 68272 +15
+ Misses 13304 13289 -15 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple trivial fixes for the tests. There wasn't really anywhere else to put these, thus this PR.
roundwithjq(not supported onjq1.5 which is the version on bionic)