-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: add flux.job.list docstrings #5500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. A few comments and corrections inline.
Can you add a commit body? I think
Would do it. |
8fba3dc
to
ad77d95
Compare
Thanks guys, I think I got all your corrections. |
bb632c8
to
d256cb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you dropped the commit body :/
d256cb8
to
b8f9ebf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @wihobbs !
Problem: Some flux.job.list functions are undocumented. Solution: Add docstrings.
b8f9ebf
to
3e8fd51
Compare
Codecov Report
@@ Coverage Diff @@
## master #5500 +/- ##
==========================================
+ Coverage 83.67% 83.70% +0.02%
==========================================
Files 484 484
Lines 81537 81537
==========================================
+ Hits 68228 68250 +22
+ Misses 13309 13287 -22
|
Checked with Hobbs, setting MWP. |
This doesn't fully document the
job.list
module but I think it's a good start.