skip "empty" lines of output in flux resource list with --skip-empty or --include
#6460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There is no way to skip lines of empty resource sets in `flux resource list`. Add a `--skip-empty` option to suppress empty lines.
Problem: When using `flux resource list --include=TARGETS`, a set of empty resource sets are generated for all configured queues. This is probably not desired behavior. Take the simple approach for now and skip empty lines if `--include` is used. In order to preserve the current behavior, also add a hidden `--no-skip-empty` option which prevents skipping empty lines. Use `--no-skip-empty` where necessary in t2350-resource-list.t to avoid breaking existing tests.
Problem: t2350-resource-list.t doesn't explicitly test that `flux resource list` skips empty lines by default with `--include`, and that `--skip-empty` skips empty lines without `--include`. Add a couple explicit tests of this behavior.
Problem: The bash tab completions for `flux resource list` do not include the `--[no-]skip-empty` flags. Add them.
Problem: The `--[no-]skip-empty` `flux resource list` options are undocumented. Add them to the flux-resource(1) manual.
|
Thanks! Will set MWP |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6460 +/- ##
==========================================
+ Coverage 83.60% 83.62% +0.01%
==========================================
Files 523 523
Lines 87552 87558 +6
==========================================
+ Hits 73201 73220 +19
+ Misses 14351 14338 -13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't really come to a resolution in issue #6275 - however, it is clear that this output is surprising and wrong:
This PR adds a
--skip-emptyoption toflux resource listto skip all lines that represent empty resource sets, then makes this the default for-i, --include(which is probably the expected and least surprising behavior). So, instead of the above, we get:There is also now a
--no-skip-emptyoption which disables the option with--include.