fix macos portability issues (third batch) #6473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: get_current_dir_name() is a glibc extension that is not available on macos. Add a simple implementation to libmissing. Update users.
Problem: prctl(2) is missing on macos Skip setting the broker proc title if PR_SET_NAME is undefined.
Problem: the flux broker fails to compile on macos because the wrong number of arguments are passed to pthread_setname_np(). Add an autoconf check for that.
grondo
approved these changes
Dec 4, 2024
src/broker/module.c
Outdated
| @@ -18,6 +18,7 @@ | |||
| #include "src/common/libmissing/argz.h" | |||
| #endif | |||
| #include <unistd.h> | |||
| #include <libgen.h> | |||
There was a problem hiding this comment.
Commit message typo: undefiend
Comment on lines
+22
to
+26
| char *basename_simple (const char *path) | ||
| { | ||
| char *p = strrchr (path, '/'); | ||
| return p ? p + 1 : (char *)path; | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh sure, we can do that. I was trying to have a light touch but this makes sense.
Problem: macos fails to compile some printfs of timeval.tv_usec because it's an int on macos. Cast where appropriate.
Problem: the shell fails to compile on macos becuase GLOB_TILDE_CHECK is a glob(3) extension unavailable on macos. Just skip the flag for now if it is undefined.
Problem: ptrace code does not compile on macos because the request names are different. If the linux request names are undefined, try the BSD ones.
Problem: rlimit code doesn't compile on macos Skip querying resource names that are not defined.
Problem: log_init() already calls basename(3) on its argument but some users do another one. Drop extra basename.
Problem: compilation fails on macos when we pass a const string value to basename(3). Add basename_simple() which does what GNU basename does and takes a const argument. Convert basename() users. Convert a couple of local functions that were doing the same thing.
|
Thanks! Everything is using |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6473 +/- ##
==========================================
- Coverage 83.64% 83.63% -0.01%
==========================================
Files 523 524 +1
Lines 87600 87595 -5
==========================================
- Hits 73271 73259 -12
- Misses 14329 14336 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some more macos portability issues.