Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop caliper support #6475

Merged
merged 1 commit into from
Dec 5, 2024
Merged

drop caliper support #6475

merged 1 commit into from
Dec 5, 2024

Conversation

garlick
Copy link
Member

@garlick garlick commented Dec 5, 2024

Problem: caliper test setfaults in CI after modifying linkage arguments for macos portability.

The caliper hooks are probably in the wrong places at this point anyway. Drop caliper support from Flux for now.

This can be reverted when someone has time to spend working on the caliper hooks and linkage.

Problem: caliper test setfaults in CI after modifying linkage arguments
for macos portability.

The caliper hooks are probably in the wrong places at this point anyway.
Drop caliper support from Flux for now.
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 861c5cf into flux-framework:master Dec 5, 2024
33 of 34 checks passed
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (01f3097) to head (ecfe518).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/common/libflux/msg_handler.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6475       +/-   ##
===========================================
+ Coverage   53.73%   83.61%   +29.87%     
===========================================
  Files         475      524       +49     
  Lines       79521    87485     +7964     
===========================================
+ Hits        42731    73148    +30417     
+ Misses      36790    14337    -22453     
Files with missing lines Coverage Δ
src/broker/broker.c 77.10% <ø> (+20.59%) ⬆️
src/broker/module.c 79.59% <ø> (+12.15%) ⬆️
src/cmd/builtin/version.c 92.30% <ø> (-0.29%) ⬇️
src/cmd/flux-start.c 83.93% <ø> (+29.38%) ⬆️
src/common/libflux/handle.c 83.98% <ø> (+5.07%) ⬆️
src/common/libflux/rpc.c 90.09% <ø> (-3.91%) ⬇️
src/common/libflux/msg_handler.c 86.54% <0.00%> (+7.88%) ⬆️

... and 440 files with indirect coverage changes

@garlick garlick deleted the drop_caliper branch December 5, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants