flux-hostlist: allow idset argument to --nth and --exclude options
#6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
force-pushed
the
flux-hostlist-tweaks
branch
2 times, most recently
from
46b94b8 to
ffa8820
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
grondo
force-pushed
the
flux-hostlist-tweaks
branch
from
ffa8820 to
bf3a55e
Compare
|
Thanks! Fixed the issue codeql flagged and forced a push. Will set MWP. |
Problem: There is no way to return a set of hosts at multiple indices in a hostlist with the flux-hostlist command. Enhance the `-n, --nth` option to accept an idset instead of a single integer.
Problem: There is no way to exclude hosts from a hostlist by index instead of hostname. Enhance `-x, --exclude` to take an idset of indices to remove in addition to the current support for a list of hosts.
Problem: The flux-hostlist `-n, --nth` option no longer needs to be in the mutually exclusive group with --expand and --count. Remove `-n, --nth` from the group so it can be used with these options.
Problem: The tests for the flux hostlist command are lacking coverage of some options. Update t2814-hostlist-cmd.t to cover new functionality.
Problem: The flux-hostlist(1) manual is out of date with resepect to recent changes to the command. Update the relevant documentation in flux-hostlist(1).
grondo
force-pushed
the
flux-hostlist-tweaks
branch
from
bf3a55e to
974dda0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6478 +/- ##
==========================================
- Coverage 83.61% 83.59% -0.03%
==========================================
Files 524 524
Lines 87485 87493 +8
==========================================
- Hits 73148 73137 -11
- Misses 14337 14356 +19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following minor improvements to
flux hostlist:-n, --nth=IDS: This option now takes an idset instead of a single index into the hostlist. This allows a user to get a "slice" of a hostlist while preserving current behavior, e.g.flux hostlist -n 0-1 JOBIDto get the first two hosts of a job.-x, --exclude=HOSTS|IDS: As suggested by @vsoch, this option now takes either a hostlist or idset or indices to exclude from the hostlist. This allows a user to exclude the first host for example withflux hostlist -x 0 localFixes #6464