shell: ignore SIGPIPE #6489
Merged
shell: ignore SIGPIPE #6489
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If a task closes stdin and the job shell tries to write data to it, the shell is immediately terminated with SIGPIPE, but it would be better to handle an EPIPE error instead of terminating the entire job. Block SIGPIPE in the job shell. Fixes flux-framework#6487
Problem: There's no test to ensure the job shell is not killed by SIGPIPE when writing data to a task that has closed stdin. Attempt to add a test for this issue. Add a note that the test is inherently racy, and it is just a best effort at this time.
|
Thanks! Setting MWP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6489 +/- ##
==========================================
+ Coverage 83.58% 83.61% +0.02%
==========================================
Files 524 524
Lines 87621 87623 +2
==========================================
+ Hits 73240 73263 +23
+ Misses 14381 14360 -21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6487 by ignoring
SIGPIPEin the job shell.At attempt at adding a test was made, but the test is inherently racy, because if the data is sent from the shell to the task before stdin is actually closed, the issue wouldn't reproduce (and also there's no way to synchronize on the job shell actually writing the data to the task, so the job could get canceled before any data is written) However, it seems sufficient for now.