track raw payload accessor API changes in core #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the raw message payload interfaces are changing to use a size_t instead of int. Update usage in interthread. flux-framework/flux-core#6467 must be merged before this will pass CI.
|
Hmm fedora34 builder doesn't seem to have updated. Oh, we are probably not pushing it anymore from flux-core. I can update that to match flux-core. |
|
Actually maybe it would be better to just remove branch protection on that builder and get this merged then update in another PR. |
garlick
added
the
merge-when-passing
|
fedora34 doesn't seem to be in required checks anyway (unless you just removed it), so feel free to set MWP. |
|
Just removed it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the raw message payload interfaces are changing to use a size_t instead of int.
Update usage in interthread.
flux-framework/flux-core#6467 must be merged before this will pass CI.