modules: Move feasibility/satisfiability checking into a new module #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtkeio
force-pushed
the
master
branch
3 times, most recently
from
c31f3e7 to
c6f6c95
Compare
jacobtkeio
force-pushed
the
master
branch
5 times, most recently
from
93b13a6 to
3d94893
Compare
jacobtkeio
force-pushed
the
master
branch
7 times, most recently
from
9e2814e to
bdb3fca
Compare
jacobtkeio
force-pushed
the
master
branch
5 times, most recently
from
6308980 to
b8f1289
Compare
jacobtkeio
force-pushed
the
master
branch
7 times, most recently
from
9b84f5d to
eae90b4
Compare
jacobtkeio
force-pushed
the
master
branch
2 times, most recently
from
1597b05 to
4970995
Compare
Problem: feasibility.check RPCs take up too much of sched-fluxion-resource's single-threaded time. Add sched-fluxion-feasibility module that can run on multiple ranks to handle feasibility.check RPCs.
Problem: All calls to feasibility.check are in tests for s-f-resource, not tests for s-f-feasibility. Move them to a separate test for the feasibility module.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1285 +/- ##
=======================================
Coverage 75.6% 75.6%
=======================================
Files 112 115 +3
Lines 16360 16543 +183
=======================================
+ Hits 12376 12523 +147
- Misses 3984 4020 +36
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Feasibility checking takes up a significant amount of sched-fluxion-resource's time that could be better spent on scheduling.
Solution: Move feasibility checking into a new module, sched-fluxion-feasibility, that can run on multiple ranks.