Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JGF simplification #1293

Merged
merged 6 commits into from
Sep 30, 2024

readers: infer node id from hostname suffix

6785369
Select commit
Loading
Failed to load commit list.
Merged

JGF simplification #1293

readers: infer node id from hostname suffix
6785369
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2024 in 0s

75.3% (-0.1%) compared to a042bbf

View this Pull Request on Codecov

75.3% (-0.1%) compared to a042bbf

Details

Codecov Report

Attention: Patch coverage is 72.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (a042bbf) to head (6785369).

Files with missing lines Patch % Lines
resource/readers/resource_reader_jgf.cpp 67.4% 14 Missing ⚠️
src/python/fluxion/resourcegraph/V1.py 78.1% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1293     +/-   ##
========================================
- Coverage    75.3%   75.3%   -0.1%     
========================================
  Files         111     111             
  Lines       15262   15298     +36     
========================================
+ Hits        11505   11530     +25     
- Misses       3757    3768     +11     
Files with missing lines Coverage Δ
resource/readers/resource_reader_jgf.hpp 100.0% <ø> (ø)
src/python/fluxion/resourcegraph/V1.py 86.7% <78.1%> (-5.3%) ⬇️
resource/readers/resource_reader_jgf.cpp 70.2% <67.4%> (+0.3%) ⬆️