Jgf writer simplification #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the JGF reader understands edges as containment by default, but the JGF writer outputs the value anyway even though it can be quite verbose. Suppress edge metadata for containment edges.
Problem: there are some extra branches in emit_vtx_base that could be cut down. Cut down the unnecessary branches.
jameshcorbett
force-pushed
the
jgf-writer-simplification
branch
from
3ff7d5c to
e7e50b6
Compare
Problem: the JGF writer outputs a lot of default data for vertices. Do not output default data, let the reader infer defaults.
jameshcorbett
force-pushed
the
jgf-writer-simplification
branch
from
e7e50b6 to
3e533c5
Compare
|
Ok @trws there is one failing test but I'm pretty sure I know what's wrong and it's just a matter of updating some JGFs after making sure everything looks sane (which is kind of slow since the JSON isn't formatted nicely so requires a lot of manual intervention). If the code looks good to you I could probably get the tests passing in time for the release tomorrow. |
Open
Problem: the JGF writer no longer outputs some default data, but the tests expect to find it. Change the tests.
jameshcorbett
force-pushed
the
jgf-writer-simplification
branch
from
3e533c5 to
c1af690
Compare
trws
approved these changes
Oct 1, 2024
|
Thanks! Setting MWP |
jameshcorbett
added
the
merge-when-passing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1299 +/- ##
========================================
- Coverage 75.3% 75.3% -0.1%
========================================
Files 111 111
Lines 15298 15297 -1
========================================
- Hits 11530 11529 -1
Misses 3768 3768
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #1293 has made the JGF reader smarter about defaults and the ion-R utility less verbose, the JGF match writer needs similar treatment.