Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add grow functions to REAPI #1316

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

milroy
Copy link
Member

@milroy milroy commented Dec 4, 2024

This PR exposes grow functions in the C and C++ REAPI bindings.

The grow functionality passes a JGF subgraph including the path from the cluster vertex to the subgraph root. For example, a JGF subgraph with a new node (newnode) and subnode resources to cluster0 at rack0 includes the cluster and rack vertices as well as the induced edges. The disadvantage of this approach is that the vertex metadata in the JGF subgraph needs to be sufficiently specified to identify the vertices that already exist in the graph (e.g., cluster0).

The PR is WIP, because we'll need to sort out whether to implement the REAPI module functions and determine if it's preferable to pass a path to the attachment point rather than include the path in the JGF subgraph.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes missing coverage. Please review.

Project coverage is 75.0%. Comparing base (3fb0b4e) to head (3d569fe).

Files with missing lines Patch % Lines
resource/reapi/bindings/c++/reapi_cli_impl.hpp 0.0% 33 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1316     +/-   ##
========================================
- Coverage    75.2%   75.0%   -0.2%     
========================================
  Files         111     111             
  Lines       15986   16021     +35     
========================================
+ Hits        12029   12031      +2     
- Misses       3957    3990     +33     
Files with missing lines Coverage Δ
resource/readers/resource_reader_jgf.cpp 70.7% <ø> (ø)
resource/utilities/command.cpp 77.7% <100.0%> (+<0.1%) ⬆️
resource/reapi/bindings/c++/reapi_cli_impl.hpp 36.4% <0.0%> (-3.0%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant