-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow refining Self
#589
Allow refining Self
#589
Conversation
Co-authored-by: Nico Lehmann <[email protected]>
Co-authored-by: Nico Lehmann <[email protected]>
Co-authored-by: Nico Lehmann <[email protected]>
Co-authored-by: Nico Lehmann <[email protected]>
@nilehmann I think I've addressed the issues would be good to take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to merge this myself because I have some big changes that are going to conflict. |
thanks! |
Updates the
Generics
type to includeSelf as base
fortrait
, so the following now works: