Skip to content
build

Remove unused methods in fixpoint::Constant + adjust documentation #73

Sign in to view logs

Remove unused methods in fixpoint::Constant + adjust documentation

Remove unused methods in fixpoint::Constant + adjust documentation #73

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Oct 31, 2023 in 1s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.74.0-nightly (b3aa8e716 2023-09-21)
  • cargo 1.74.0-nightly (b4ddf95ad 2023-09-18)
  • clippy 0.1.74 (b3aa8e7 2023-09-21)

Annotations

Check warning on line 476 in crates/flux-macros/src/diagnostics/subdiagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

consider adding a `;` to the last statement for consistent formatting 

warning: consider adding a `;` to the last statement for consistent formatting
   --> crates/flux-macros/src/diagnostics/subdiagnostic.rs:476:25
    |
476 |                         span_attrs.push("primary_span")
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `span_attrs.push("primary_span");`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

Check warning on line 386 in crates/flux-macros/src/diagnostics/subdiagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

consider adding a `;` to the last statement for consistent formatting 

warning: consider adding a `;` to the last statement for consistent formatting
   --> crates/flux-macros/src/diagnostics/subdiagnostic.rs:386:21
    |
386 |                     span_attrs.push("primary_span")
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `span_attrs.push("primary_span");`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

Check warning on line 305 in crates/flux-macros/src/diagnostics/fluent.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

it is more concise to loop over containers instead of using explicit iteration methods 

warning: it is more concise to loop over containers instead of using explicit iteration methods
   --> crates/flux-macros/src/diagnostics/fluent.rs:305:25
    |
305 |     for (mref, name) in message_refs.into_iter() {
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `message_refs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_into_iter_loop
    = note: requested on the command line with `-W clippy::explicit-into-iter-loop`

Check warning on line 301 in crates/flux-macros/src/diagnostics/fluent.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

consider adding a `;` to the last statement for consistent formatting 

warning: consider adding a `;` to the last statement for consistent formatting
   --> crates/flux-macros/src/diagnostics/fluent.rs:298:13
    |
298 | /             constants.extend(quote! {
299 | |                 #[cfg(test)]
300 | |                 pub const #ident: &[&str] = &[#(#vrefs),*];
301 | |             })
    | |______________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
    = note: requested on the command line with `-W clippy::semicolon-if-nothing-returned`
help: add a `;` here
    |
298 ~             constants.extend(quote! {
299 +                 #[cfg(test)]
300 +                 pub const #ident: &[&str] = &[#(#vrefs),*];
301 +             });
    |

Check warning on line 476 in crates/flux-macros/src/diagnostics/subdiagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

consider adding a `;` to the last statement for consistent formatting 

warning: consider adding a `;` to the last statement for consistent formatting
   --> crates/flux-macros/src/diagnostics/subdiagnostic.rs:476:25
    |
476 |                         span_attrs.push("primary_span")
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `span_attrs.push("primary_span");`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

Check warning on line 386 in crates/flux-macros/src/diagnostics/subdiagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

consider adding a `;` to the last statement for consistent formatting 

warning: consider adding a `;` to the last statement for consistent formatting
   --> crates/flux-macros/src/diagnostics/subdiagnostic.rs:386:21
    |
386 |                     span_attrs.push("primary_span")
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `span_attrs.push("primary_span");`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

Check warning on line 305 in crates/flux-macros/src/diagnostics/fluent.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

it is more concise to loop over containers instead of using explicit iteration methods 

warning: it is more concise to loop over containers instead of using explicit iteration methods
   --> crates/flux-macros/src/diagnostics/fluent.rs:305:25
    |
305 |     for (mref, name) in message_refs.into_iter() {
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `message_refs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_into_iter_loop
    = note: requested on the command line with `-W clippy::explicit-into-iter-loop`

Check warning on line 202 in crates/flux-macros/src/diagnostics/fluent.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

calling `to_string` on `&&str` 

warning: calling `to_string` on `&&str`
   --> crates/flux-macros/src/diagnostics/fluent.rs:202:24
    |
202 |                 .entry(name.to_string())
    |                        ^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*name).to_string()`
    |
    = help: `&str` implements `ToString` through a slower blanket impl, but `str` has a fast specialization of `ToString`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inefficient_to_string
    = note: requested on the command line with `-W clippy::inefficient-to-string`

Check warning on line 301 in crates/flux-macros/src/diagnostics/fluent.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

consider adding a `;` to the last statement for consistent formatting 

warning: consider adding a `;` to the last statement for consistent formatting
   --> crates/flux-macros/src/diagnostics/fluent.rs:298:13
    |
298 | /             constants.extend(quote! {
299 | |                 #[cfg(test)]
300 | |                 pub const #ident: &[&str] = &[#(#vrefs),*];
301 | |             })
    | |______________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
    = note: requested on the command line with `-W clippy::semicolon-if-nothing-returned`
help: add a `;` here
    |
298 ~             constants.extend(quote! {
299 +                 #[cfg(test)]
300 +                 pub const #ident: &[&str] = &[#(#vrefs),*];
301 +             });
    |
View more details on GitHub Actions