Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix virtual service destination routes when match is set #1668

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Jun 27, 2024

  1. fix virtual service destination routes when match is set in the analy…

    …sis config
    
    primary destination is duplicated on both virtual service routes when setting match rules as per the [istio a/b testing](https://docs.flagger.app/tutorials/istio-ab-testing) tutorial:
    ```yaml
      http:
      - match:
        - headers:
            x-header-1:
              exact: Test_from_DEVs
        route:
        - destination:
            host: podinfo-primary
          weight: 50
        - destination:
            host: podinfo-canary
          weight: 50
      - route:
         - destination:
             host: podinfo-primary
            weight: 50
    ```
    this PR removes the primary destination from canary route to generate and update the virtual service without the duplicate destination:
    ```yaml
      http:
      - match:
        - headers:
            x-header-1:
              exact: Test_from_DEVs
        route:
        - destination:
            host: podinfo-canary
          weight: 50
      - route:
        - destination:
            host: podinfo-primary
           weight: 50
    ```
    
    Signed-off-by: luisr-escobar <[email protected]>
    luisr-escobar authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    208d1cd View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. default all traffic to canary deployment

    Signed-off-by: luisr-escobar <[email protected]>
    luisr-escobar authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    36a91bd View commit details
    Browse the repository at this point in the history
  2. Update istio.go

    Signed-off-by: luisr-escobar <[email protected]>
    luisr-escobar authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5d54158 View commit details
    Browse the repository at this point in the history
  3. revert makedestionation changes

    Signed-off-by: luisr-escobar <[email protected]>
    luisr-escobar authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ebbc4d2 View commit details
    Browse the repository at this point in the history