-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation on talos.dev #25
Conversation
I am not a talos user today, but I may be one tomorrow... I am interested in checking this out and understanding if we support talos appropriately today, thanks for reporting this @gecube 🥇 |
@kingdonb any chance that it would be accepted? I don't like hanging PRs and stale branches |
@gecube Yes we discussed this at Bug Scrub yesterday, but I didn't get around to updating the issue here. I think we should expand support for talos, and I'd like to begin testing it myself. Immediately! It is going to take me at least one more day to get my local dev environment up. But if we have one more Talos user here who can chime in and commit to report issues like this when we spot them, who can validate this change makes sense, I'd be glad to merge it. Only problem is I do not have write access here. @fluxcd/maintainers Do we have a policy about write access to example repos? I think maybe they would fall under website/community and I should have access already. Or the example repos ought to have a MAINTAINERS file of their own, and I'll apply to be maintainer for the various docs repos. I don't think I should be core maintainer, I don't have the golang experience to merge PRs in any old repo, but I can help in any of these example repos (and I'd volunteer for this.) |
pod-security.kubernetes.io/warn: baseline | ||
pod-security.kubernetes.io/audit: baseline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will issue events and will fill the audit log at every reconciliation, do we really need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that "yes". I don't think that it will hurt anyway. So ... do you recommend me to remove these annotations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it will hurt anyway.
I think it does, storing the audit log is expensive, and with baseline in there we just inflate the cost and storage.
Does Talos work without them?
from fluxcd#25 (testing, do we need the others as well) Signed-off-by: Kingdon P Barrett <[email protected]>
We're testing today in Bug Scrub:
This is the daemonset which is not getting any pods fulfilled, preventing the HelmRelease from suceeding. All of the non daemonset pods are fine. The talos pod security docs mention only the one label: https://www.talos.dev/v1.6/kubernetes-guides/configuration/pod-security/ I've applied that one label and it does allow the HelmRelease to complete successfully, in my testing |
@kingdonb @stefanprodan thanks for your comments and testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @gecube
When installing on talos.dev the prometheus is not running.
The issue is using of PodSecurityConfiguration
There some labels must be present on NS monitoring
I fixed it
I am kindly asking to accept this PR.