Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow proxy during SSH host key scan in FluxCD CLI #827

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

allow proxy during SSH host key scan in FluxCD CLI #827

wants to merge 2 commits into from

Commits on Nov 27, 2024

  1. use proxy.Dial instead of net.Dial for ScanHostKey 

    ssh.Dial uses net.DialTimeout under the hood
and there is no possibility to use a proxy
when running command like `flux create source git`

so we use almost all internal implementation of ssh.Dial
except net.DialTimeout is replaced with proxy.Dial
like it is done in go-git

Signed-off-by: Artem Nistratov <[email protected]>
    @adone
    adone committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    63c6588 View commit details
    Browse the repository at this point in the history

  2. imitate ssh.Dial func for simplicity 

    previously ScanHostKey ignored any SSH/network errors
in case it managed to get host keys

to make it more obvious we imitate `ssh.Dial` with `sshDial` func

Signed-off-by: Artem Nistratov <[email protected]>
    @adone
    adone committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ddb3fd8 View commit details
    Browse the repository at this point in the history