Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve url encoded path in normalized helm repository URL #1203

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Preserve url encoded path in normalized helm repository URL #1203

merged 1 commit into from
Aug 23, 2023

Conversation

somtochiama
Copy link
Member

This pull request ensures that the URL encoded path in the URL is preserved when using NormalizedURL

Previously:

repository.NormalizeURL(http://example.com/next%2Fpath) => http://example.com/next/path/

Now

repository.NormalizeURL(http://example.com/next%2Fpath) => http://example.com/next%2Fpath/

Fix: #1206

@somtochiama somtochiama added bug Something isn't working area/helm Helm related issues and pull requests labels Aug 22, 2023
aryan9600
aryan9600 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aryan9600 aryan9600 added the backport:release/v1.0.x To be backported to release/v1.0.x label Aug 22, 2023
@stefanprodan
Copy link
Member

@somtochiama please rebase

@somtochiama
preserve url encoded path in helm repo
64139e7 
Signed-off-by: Somtochi Onyekwere <[email protected]>
@stefanprodan stefanprodan merged commit b3036f5 into fluxcd:main Aug 23, 2023
10 checks passed
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.0.x:

@fluxcdbot fluxcdbot mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 aryan9600 approved these changes

@hiddeco hiddeco hiddeco approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

@darkowlzz darkowlzz Awaiting requested review from darkowlzz

Assignees
No one assigned
Labels
area/helm Helm related issues and pull requests backport:release/v1.0.x To be backported to release/v1.0.x bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create chart from Gitlab Helm repo using urlencoded path
5 participants
@somtochiama @stefanprodan @fluxcdbot @hiddeco @aryan9600