-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosign: allow identity matching for keyless verification #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
added
enhancement
New feature or request
area/security
Security related issues and pull requests
area/oci
OCI related issues and pull requests
labels
Oct 5, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
from
October 5, 2023 12:12
5b3d641
to
9e3cc30
Compare
stefanprodan
reviewed
Oct 5, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
from
October 6, 2023 14:53
213d780
to
3869d94
Compare
stefanprodan
reviewed
Oct 6, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
from
October 6, 2023 15:18
3869d94
to
dea0e1d
Compare
stefanprodan
reviewed
Oct 6, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
2 times, most recently
from
October 9, 2023 09:43
c16697c
to
8b69555
Compare
stefanprodan
reviewed
Oct 9, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
2 times, most recently
from
October 10, 2023 16:27
dd648db
to
b60cbe2
Compare
stefanprodan
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @aryan9600 🥇
darkowlzz
reviewed
Oct 12, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
3 times, most recently
from
October 13, 2023 11:22
22c9fb3
to
f77b0ce
Compare
darkowlzz
reviewed
Oct 17, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
2 times, most recently
from
October 18, 2023 20:02
e031b44
to
fda2259
Compare
darkowlzz
reviewed
Oct 19, 2023
aryan9600
force-pushed
the
cosign-identity-matching
branch
2 times, most recently
from
October 23, 2023 10:48
7ec83f8
to
ab285ca
Compare
darkowlzz
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion.
Otherwise, it LGTM.
Add `.spec.verify.matchOIDCIdentity` to OCIRepository and HelmChart. It allows specifying regular expressions to match against the subject and issuer of the certificate related to the artifact signature. Its used only if the artifact was signed using Cosign keyless signing. Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
cosign-identity-matching
branch
from
October 31, 2023 15:04
ab285ca
to
fcaf86e
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
API related issues and pull requests
area/oci
OCI related issues and pull requests
area/security
Security related issues and pull requests
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
.spec.verify.matchOIDCIdentity
to OCIRepository and HelmChart. It allows specifying a regexp to match against the subject and issuer of the certificate related to the artifact signature, if the artifact was signed using Cosign keyless signing.