Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Bucket API to v1 #1592

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Promote Bucket API to v1 #1592

merged 6 commits into from
Aug 28, 2024

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan added area/bucket Bucket related issues and pull requests area/api API related issues and pull requests labels Aug 23, 2024
@stefanprodan stefanprodan added this to the Bucket GA milestone Aug 23, 2024
@stefanprodan
Promote Bucket API to v1
5be0c53 
Signed-off-by: Stefan Prodan <[email protected]>
@stefanprodan stefanprodan mentioned this pull request Aug 23, 2024
Closed
57 tasks
@stefanprodan stefanprodan marked this pull request as ready for review August 23, 2024 12:14
matheuscscp
matheuscscp approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

config/crd/bases/source.toolkit.fluxcd.io_gitrepositories.yaml Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Aug 23, 2024
View reviewed changes
api/v1/bucket_types.go Outdated Show resolved Hide resolved
api/v1beta2/bucket_types.go Outdated Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Aug 26, 2024
View reviewed changes
api/v1beta2/bucket_types.go Outdated Show resolved Hide resolved
api/v1beta2/bucket_types.go Show resolved Hide resolved
internal/controller/bucket_controller.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
darkowlzz
darkowlzz approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comment about consistency in deprecation message above, it LGTM!

@stefanprodan stefanprodan merged commit 53f7581 into main Aug 28, 2024
9 checks passed
@stefanprodan stefanprodan deleted the bucket-v1-ga branch August 28, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheuscscp matheuscscp matheuscscp approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/api API related issues and pull requests area/bucket Bucket related issues and pull requests
Projects
None yet
Milestone
Bucket GA
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanprodan @darkowlzz @matheuscscp