Use separate API for wingman #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligaz
reviewed
Aug 7, 2024
|
|
||
| export const getFlyCIUrl = (path: string = "") => { | ||
| const url = core.getInput("flyci-url") || FLYCI_URL; | ||
|
|
||
| return `${url}${path}`; | ||
| }; | ||
|
|
||
| export const getWingmanUrl = () => core.getInput("wingman-url") || WINGMAN_URL; |
There was a problem hiding this comment.
Can you add a unit test for the scenario when the URL is passed as input?
ligaz
reviewed
Aug 7, 2024
src/__tests__/wingman.test.ts
Outdated
Comment on lines
90
to
91
| process.env[wingmanUrlEnv] = "mock-url"; | ||
| mockExec.mockResolvedValueOnce(0); |
There was a problem hiding this comment.
I will go with mocking core.getInput() instead of relying on its internal implementation.
There was a problem hiding this comment.
What I don't like about mocking is that this would also mock getInput for the "flyci-url" which can potentially make the test not that reliable unless we use mockImplementation and check if the input is "wingman-url". Otherwise the test will pass even if we use getFlyciUrl instead of getWingmanUrl
There was a problem hiding this comment.
opted for verifying of getInput was called with wingman-url the second time
harveysmurf
force-pushed
the
use-rest-api-for-wingman-url
branch
from
b9f6835
to
001a38e
Compare
ligaz
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new REST API Gateway for the wingman llm proxy