Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380/pfd): FMA code cleanup & update possible fmas #9501

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Nov 12, 2024

Fixes #[issue_no]

Summary of Changes

Cleanup reference to FINAL APP in PFD FMA file as it doesn't exist on the A380.
Updates possible FMA list with OP CLB blue, RWY blue, RWY + NAV blue, ALT CRZ * & ALT CRZ blue
(These are not hooked to anything as it require implementation on the simulink model).

Screenshots (if necessary)

FMA2
FMA1
ALT CRZ

References

image
image
image
image

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

  1. Regression test: Perform a flight and verify the FMA modes still work as before, more specifically, armed vertical & lateral modes alongside ALT*. Note: The modes in the screenshot (ALT CRZ * ALT CRZ Blue Open Climb blue & runway blue) are not supposed to work.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BravoMike99 BravoMike99 added the A380X Related to the A380X aircraft label Nov 12, 2024
@beheh
Copy link
Member

beheh commented Nov 12, 2024

Are you sure ALT CRZ can be armed/ALT CRZ* can be engaged I thought it was ALT blue, ALT*, and then it turns into ALT CRZ. Maybe check with one of our autoflight gurus such as @lukecologne.

@BravoMike99
Copy link
Contributor Author

Are you sure ALT CRZ can be armed/ALT CRZ* can be engaged I thought it was ALT blue, ALT*, and then it turns into ALT CRZ. Maybe check with one of our autoflight gurus such as @lukecologne.

Yes, since the A330 it can.
image
image

@alexr4339
Copy link

alexr4339 commented Nov 17, 2024

Quality Assurance Tester

Discord Username : alexdnzdmb
Object of testing : #9501
Aircraft : A380X
Tier of Testing : 1
Date : 17/11/2024

Testing Process:
Initialized LPPT to LPPT with a SID and approach. Flight level for that flight was defined as FL080 in the FMS. Departed, did a direct to PT718 (or similar) and checked FMA. Prior to reacing that point, I self vectored myself. When interecepting FL080, ALT CRZ* should have triggered but didnt (desired/expected that it didnt trigger). IIRC when ALT* triggered I was still in QNH mode and not STD baro. When being on FL080, ALT CRZ triggered.

image
image

Testing Results:
Passed

Negatives:

Conclusions:

Media:

@beheh
Copy link
Member

beheh commented Nov 18, 2024

@alexr4339 Please carefully re-read the testing instructions. This is a regression test only, the new modes are not hooked up to anything yet.

@BravoMike99
Copy link
Contributor Author

@alexr4339 Please carefully re-read the testing instructions. This is a regression test only, the new modes are not hooked up to anything yet.

I had coordinated with alex over discord after the fail and asked a retest (which now is a pass/PR commented has been edited after a new flight). The testing instructions were updated after the initial "fail" to make it more clear for the retest.

@beheh
Copy link
Member

beheh commented Nov 18, 2024

Ah, great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⌛ Awaiting Actions
Development

Successfully merging this pull request may close these issues.

5 participants