feat(a380x/mfd): Vertical Revision speed limit modification #9845
+472
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
reviewed
Feb 10, 2025
fbw-a32nx/src/systems/fmgc/src/flightplanning/plans/performance/FlightPlanPerformanceData.ts
Outdated
Show resolved
Hide resolved
BravoMike99
force-pushed
the
mfd-cstr-tmp-spd-lim
branch
from
335d966 to
c9b8974
Compare
tracernz
reviewed
Feb 15, 2025
fbw-a32nx/src/systems/fmgc/src/flightplanning/plans/performance/FlightPlanPerformanceData.ts
Outdated
Show resolved
Hide resolved
tracernz
reviewed
Feb 15, 2025
fbw-a32nx/src/systems/fmgc/src/flightplanning/FlightPlanService.ts
Outdated
Show resolved
Hide resolved
This reverts commit 3b17e1f.
BravoMike99
force-pushed
the
mfd-cstr-tmp-spd-lim
branch
from
da614c7 to
f5ef74e
Compare
tracernz
reviewed
Feb 17, 2025
| plan.setPerformanceData(alternate ? 'alternateClimbSpeedLimitAltitude' : 'climbSpeedLimitAltitude', null); | ||
| plan.setPerformanceData( | ||
| alternate ? 'isAlternateClimbSpeedLimitPilotEntered' : 'isClimbSpeedLimitPilotEntered', | ||
| false, |
There was a problem hiding this comment.
Deletion would be setting a pilot value of null IMO? Anything setting it to a non-default value would be a pilot entry.
There was a problem hiding this comment.
I kept it as false for consistency as that's how it also is on the A32NX currently (default entry or deleted -> false). I can change both to null but in that case I need to update the performance data interface as the type there is just boolean currently.
tracernz
reviewed
Feb 17, 2025
Comment on lines
303
to
313
| setPilotEntryClimbSpeedLimitSpeed(value: number, planIndex: FlightPlanIndex, alternate: boolean): Promise<void>; | ||
|
|
||
| setPilotEntryClimbSpeedLimitAltitude(value: number, planIndex: FlightPlanIndex, alternate: boolean): Promise<void>; | ||
|
|
||
| deleteClimbSpeedLimit(planIndex: FlightPlanIndex, alternate: boolean): Promise<void>; | ||
|
|
||
| setPilotEntryDescentSpeedLimitSpeed(value: number, planIndex: FlightPlanIndex, alternate: boolean): Promise<void>; | ||
|
|
||
| setPilotEntryDescentSpeedLimitAltitude(value: number, planIndex: FlightPlanIndex, alternate: boolean): Promise<void>; | ||
|
|
||
| deleteDescentSpeedLimit(planIndex: FlightPlanIndex, alternate: boolean): Promise<void>; |
There was a problem hiding this comment.
These should all have full JSDocs for all parameters with unit and possible values (as should the existing ones, but too late for them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9841
Fixes #8962
Summary of Changes
Adds modification of speed limit through vertical revision page.
Fixes delete altitude & speed constraint button not generating a temporary flightplan.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
Program a flight plan of your choice on the FMS.
With an altitude constraint entered on a waypoint, press the "DELETE ALT CSTR" button on the ALT VERT REV page. After doing so, verify a TMPY FPLN is generated and that the constraint is deleted after inserting it.
Repeat the previous process but for a speed constraint on the SPD VERT REV page.
On the MFD, select a waypoint with a climb speed constraint or with no constraint at all (if on the ground) & access the SPD VERT page. "CLB SPD LIM" should be shown like the above picture with a 250K 10000feet value (if above transition altitude, it will be shown as flight level).
Attempt to delete the SPD LIM via the input fields or the button. A temporary flight plan is generated and after insertion the "SPD LIM" disappears from the F-PLN page and the calculated speeds are no longer limited by such restriction.
With a previously deleted speed limit, access the vert revision page again and insert a value in the speed or altitude fields. After doing so, the other should be populated with 250kt if an altitude was inserted or 10000 feet if a speed was inserted. The fields should become bigger after a manual entry.
Play around with editing the speed limit fields and verify the speed limit is correctly updated on the PERF CLB (only visible on the ground currently) and on the F-PLN page.
Repeat the previous process but for the descent speed limit, In order to edit the descent speed limit the waypoint in question needs to have a descent speed constraint or the FMS must be in the descent phase. (You can always add a descent constraint yourself)
Verify that the magenta speed bug & the autopilot respect the speed limit after a manual edition and that the speed is not limited by it after deletion.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.