Better error message if batou deployment is already runnning #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zagy
requested changes
Oct 15, 2024
src/batou/utils.py
Outdated
| # XXX can we make this not leave files around? | ||
| with open(filename, "a+") as lockfile: | ||
| try: | ||
| fcntl.lockf(lockfile, fcntl.LOCK_EX | fcntl.LOCK_NB) | ||
| except IOError: | ||
| print("Could not acquire lock {}".format(filename), file=sys.stderr) | ||
| if exit_on_failure: | ||
| print( | ||
| "Another instance of batou may be running, or a stale lock file may exist.", |
There was a problem hiding this comment.
The message is misleading. The lockfile is never deleted.
zagy
previously approved these changes
Oct 15, 2024
zagy
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #446