refactor: create the join string by Stream's Collectors.join() method

flyisland · Nov 7, 2021 · 3402a97 · 3402a97
1 parent e0ebd80
commit 3402a97
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/com/solace/tools/solconfig/model/ConfigObject.java b/src/main/java/com/solace/tools/solconfig/model/ConfigObject.java
@@ -128,12 +128,13 @@ private StringBuilder childrenToJsonString(int level) {
      * @return the obj-id
      */
     public String getObjectId() {
-        var idList = sempSpec.getAttributeNames(AttributeType.IDENTIFYING).stream()
+        var result = sempSpec.getAttributeNames(AttributeType.IDENTIFYING).stream()
                 // Identifying attributes might not be required attributes, like "/msgVpns/bridges/remoteMsgVpns"
+                // If an identifying attribues is absent, use a empty string
                 .map(id -> Optional.ofNullable(attributes.get(id)).orElse("").toString())
                 .map(ConfigObject::percentEncoding)
-                .collect(Collectors.toList());
-        return String.join(",", idList);
+                .collect(Collectors.joining(","));
+        return result;
     }
 
     static String percentEncoding(String input){