move GetDomains function, return GetDomainsResponse

Signed-off-by: zychen5186 <[email protected]>
flyteorg · Jun 12, 2024 · 93979fa · 93979fa
1 parent 4b4fd7f
commit 93979fa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/flytectl/pkg/ext/domain_fetcher.go b/flytectl/pkg/ext/domain_fetcher.go
@@ -6,7 +6,7 @@ import (
 	"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/admin"
 )
 
-func (a *AdminFetcherExtClient) GetDomains(ctx context.Context) (*admin.Domains, error) {
+func (a *AdminFetcherExtClient) GetDomains(ctx context.Context) (*admin.GetDomainsResponse, error) {
 	domains, err := a.AdminServiceClient().GetDomains(ctx, &admin.GetDomainRequest{})
 	if err != nil {
 		return nil, err

diff --git a/flytectl/pkg/ext/domain_fetcher_test.go b/flytectl/pkg/ext/domain_fetcher_test.go
@@ -22,7 +22,7 @@ func TestAdminFetcherExtClient_GetDomains(t *testing.T) {
 		Id:   "production",
 		Name: "production",
 	}
-	domains := &admin.Domains{
+	domains := &admin.GetDomainsResponse{
 		Domains: []*admin.Domain{domain1, domain2, domain3},
 	}
 

diff --git a/flytectl/pkg/ext/fetcher.go b/flytectl/pkg/ext/fetcher.go
@@ -76,7 +76,7 @@ type AdminFetcherExtInterface interface {
 	// GetProjectByID fetches a single project by its identifier. If project does not exist, an error will be returned
 	GetProjectByID(ctx context.Context, projectID string) (*admin.Project, error)
 
-	GetDomains(ctx context.Context) (*admin.Domains, error)
+	GetDomains(ctx context.Context) (*admin.GetDomainsResponse, error)
 }
 
 // AdminFetcherExtClient is used for interacting with extended features used for fetching data from admin service

diff --git a/flytectl/pkg/ext/mocks/admin_fetcher_ext_interface.go b/flytectl/pkg/ext/mocks/admin_fetcher_ext_interface.go